Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , I am strongly in favor of your decision to keep the
bundles-lib and bundles-maven-plugin at the top level. Since they are clones
of external functionality, they should be kept as independent of the rest of
Metron as possible, so as to ease future updates to track advances in the NiFi
implementation.
I recommend that you pick a _release version_ of NiFi NAR to clone. This
will (a) help give known quality, as releases are usually subjected to more
testing than individual commits; (b) ease tracking bugs and patches, since
formal releases are usually better documented as to what is and isn't in them,
and (c) allow comparison by tag instead of commit number.
* The latest released version of nifi-maven is
`rel/nifi-nar-maven-plugin-1.2.0` tag, at SHA1= d0c9d46 from 14 Mar 2017. This
is the same as current master, except for a version change in preparation for
the next development cycle. So I suggest you undo (reverse-apply) patch
fc124e5, to revert the version designation to the released version. If that's
still meaningful in your modified version, where I hope you've kept a record of
where it came from.
* The latest released version of nifi, and hence of the path
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/ , is
`rel/nifi-1.3.0` tag at SHA1=ddb7361 from 5 Jun 2017. That's both the overall
NiFi SHA1 commit, and the latest change on nifi-nar-utils subdirectory. This
is somewhat newer than your current reference SHA1 of d90cf84 on 24 Mar 2017.
There is a substantive change on 6 Apr, "NIFI-3520 Refactory instance class
loading" which includes sub-task "Refactoring nifi-nar-utils so that
ExtensionManager only lives in nifi-framework". So please consider updating to
the nifi-1.3.0 release version. If this is prohibitively difficult, let us
know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
