GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/672
METRON-1047: REST should use core-site.xml for Hadoop configuration
## Contributor Comments
This PR removes the explicit HDFS url property from the REST application
and instead relies on core-site.xml for that property. This makes the REST
code simpler to configure and is more in line with how most HDFS clients work.
This should also enable the REST application to work in HFDS HA mode.
I have verified all unit/integration tests and tested in full dev with
Kerberos enabled. To test this, navigate to Swagger in full dev and execute
the various hdfs-controller methods. They should all work without issue.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1047
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #672
----
commit 33d9d97f2866c15c703c6e654cc89478c5c1838a
Author: merrimanr <[email protected]>
Date: 2017-07-14T19:08:02Z
initial commit
commit 23eeab6ad2457f63a940b629c4f3fed9e228f2c7
Author: merrimanr <[email protected]>
Date: 2017-07-26T18:01:36Z
Merge remote-tracking branch 'mirror/master' into METRON-1047
# Conflicts:
# metron-interface/metron-rest/src/main/scripts/metron-rest
commit 71dc342f9e39ce6e54e5252a5fb2991d83c757e8
Author: merrimanr <[email protected]>
Date: 2017-07-26T18:44:17Z
removed hdfs url property
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
