GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/706
METRON-1119 Bad Out-of-Order Logic for SaltyRowKeyBuilder
This is a bug that was previously Identified by @mattf-horton
https://github.com/apache/metron/pull/622#pullrequestreview-51351898
The 'out-of-order' logic for the `SaltyRowKeyBuilder.encode` function does
not work.
> If it starts out in the wrong order, say end is 1 and start is 5, won't
this pair of statements result in both end and start being equal to the larger,
ie 5 ? We need an intermediate variable for a binary swap!
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1119
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #706
----
commit b00888654458de1a280aff556567fe8f9f51d92c
Author: Nick Allen <[email protected]>
Date: 2017-08-17T23:54:07Z
METRON-1119 Bad Out-of-Order Logic for SaltyRowKeyBuilder
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
