Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/712#discussion_r134802794
  
    --- Diff: metron-deployment/packaging/docker/rpm-docker/Dockerfile ---
    @@ -27,3 +27,7 @@ RUN mv apache-maven-3.2.5 /opt/maven
     RUN ln -s /opt/maven/bin/mvn /usr/bin/mvn
     RUN yum -y install asciidoc rpm-build rpm2cpio tar unzip xmlto zip rpmlint 
&& yum clean all
     WORKDIR /root
    +
    +# install node so that the node dependencies can be packaged into the RPMs
    +RUN curl --silent --location https://rpm.nodesource.com/setup_6.x | bash -
    +RUN yum -y install gcc-c++ make nodejs
    --- End diff --
    
    Right now, we copy everything we need into the docker rpm environment using 
assembly and resource copy.  Since we have *just* built the node stuff in the 
build phase, is there a way we can assemble and resource copy the node 
dependencies in?  or does this have to be done on the spot regardless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to