Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/711#discussion_r135898556
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.rest.service.impl;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import java.util.Map;
+import org.apache.metron.common.utils.JSONUtils;
+import org.apache.metron.rest.MetronRestConstants;
+import org.apache.metron.rest.RestException;
+import org.apache.metron.rest.service.AlertService;
+import org.apache.metron.rest.service.KafkaService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.core.env.Environment;
+import org.springframework.stereotype.Service;
+
+/**
+ * The default service layer implementation of {@link AlertService}.
+ *
+ * @see AlertService
+ */
+@Service
+public class AlertServiceImpl implements AlertService {
+
+ private Environment environment;
+ private final KafkaService kafkaService;
+
+ @Autowired
+ public AlertServiceImpl(final KafkaService kafkaService,
+ final Environment environment) {
+ this.kafkaService = kafkaService;
+ this.environment = environment;
+ }
+
--- End diff --
> Yes the endpoint expects all alert data to be passed in. I'm trying to
avoid an extra ES call (alert data will travel across the network either way).
I think @merrimanr 's implementation makes the most sense right now. We
assume the client has all of the necessary details about the alert that they
want to escalate. Adding extra logic to pull the freshest version from the
index (ES) does not make sense to me.
As a SOC analyst using the Alerts UI, if I escalate an alert, I want to
know that what I am seeing on my screen is what I actually escalated. I
escalated the alert based on the information that I had in front of me; it is a
point-in-time snapshot.
If the alert changes between the time that I loaded the alert on my screen
and when I clicked escalate, then that is a condition that can only be
correctly recovered from in the UI, not in the REST API.
In addition, the result of escalation here is that we are pushing data into
a Kafka topic. The only reasonable expectation is that this data is a
point-in-time snapshot. We don't need to jump through hoops to try and sync
with any changes in the index.
If the alerts data needs refreshed, then the consumer of the 'escalation'
Kafka topic needs to do that. Whether the data needs refreshed and how fresh
that needs to be are decisions that only the consumer of that topic can make.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
