GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/743
METRON-1163 RAT failures for metron-interface/metron-alerts
## Contributor Comments
Please see https://issues.apache.org/jira/browse/METRON-1163 for the
problem.
I'm not entirely pleased with excluding 3rdpartylicenses.txt, as if it
changes in future to non-empty, we could miss it. Alternative suggestions
welcome.
This is required for the 0.4.1 release, else RAT doesn't pass.
Reproduce:
This problem seems to only reproduce when one unrolls a tarball rather than
cloning from github.
Do:
```
mkdir workdir; cd workdir
wget
https://dist.apache.org/repos/dist/dev/metron/0.4.1-RC3/apache-metron-0.4.1-rc3.tar.gz
tar xvzf apache-metron-0.4.1-rc3.tar.gz
cd apache-metron-0.4.1-rc3
mvn clean
mvn install -DskipTests
```
When it comes to metron-alerts module, apache-rat-plugin should error,
complaining about:
```
Files with unapproved licenses:
.../metron-interface/metron-alerts/dist/3rdpartylicenses.txt
.../metron-interface/metron-alerts/dist/styles.a0b6b99c10d9a13dc67e.bundle.css
```
To test the patch, while in directory apache-metron-0.4.1-rc3 do:
```
curl -s -S
https://issues.apache.org/jira/secure/attachment/12886172/METRON-1163.patch | \
patch -p 1
```
then re-run the mvn command (or just do `mvn install -DskipTests -rf
:metron-alerts`) and it should pass.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [NA] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [NA] Have you written or updated unit tests and or integration tests to
verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [NA] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [NA] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/metron METRON-1163
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/743.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #743
----
commit 5b10b544874c6100f7449cedd495669ac7b8c3af
Author: mattf-horton <[email protected]>
Date: 2017-09-08T01:27:52Z
METRON-1163 RAT failures for metron-interface/metron-alerts
----
---
