[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/742#discussion_r137913079
  
    --- Diff: 
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/StringFunctionsTest.java
 ---
    @@ -408,6 +408,23 @@ public void testAppendIfMissing() throws Exception {
     
       }
     
    +  @Test
    +  public void testSubstring() throws Exception {
    +    Map<String, Object> variables = ImmutableMap.of("s", "apache metron");
    --- End diff --
    
    To go with type validation, tests with passing down incorrect types.
    
    like : SUBSTRING(s,'7',9)


---