Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/750#discussion_r138506017
  
    --- Diff: 
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java
 ---
    @@ -141,8 +141,21 @@ public Object apply(List<Object> args) {
     
           // add each of the numeric values
           for(int i=1; i<args.size(); i++) {
    -        double value = convert(args.get(i), Double.class);
    -        stats.addValue(value);
    +        Object n = args.get(i);
    +        if( n != null) {
    +          if(n instanceof Iterable) {
    +            for(Object num : (Iterable<Object>)n) {
    +              if(num != null) {
    --- End diff --
    
    Just a nit, but why 'double' and not Double?
    Is there a reason to box?


---

Reply via email to