Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139171727
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -346,19 +434,56 @@ public static void
setupStellarStatically(CuratorFramework client, Optional<Stri
}
public static Map<String, byte[]> readSensorConfigsFromFile(String
rootPath, ConfigurationType configType) throws IOException {
+ return readSensorConfigsFromFile(rootPath, configType,
Optional.empty());
+ }
+
+ public static Map<String, byte[]> readSensorConfigsFromFile(String
rootPath,
--- End diff --
Would you mind adding Javadocs while you're already in the functions?
---
