Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/779#discussion_r142419159
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
 ---
    @@ -35,7 +36,7 @@
       @ResponseBody
       ResponseEntity<?> handleControllerException(HttpServletRequest request, 
Throwable ex) {
         HttpStatus status = getStatus(request);
    -    return new ResponseEntity<>(new RestError(status.value(), 
ex.getMessage(), getFullMessage(ex)), status);
    +    return new ResponseEntity<>(new RestError(status.value(), 
ex.getMessage(), ExceptionUtils.getStackTrace(ex)), status);
    --- End diff --
    
    My vote would be root cause in the REST response, full stack trace in the 
logs.  I would also vote to skip the separate profile for stack trace.  Turning 
that on and restarting REST would be more effort than just looking at the log.  
Doubt anyone would use it.
    
    I think this is a minor issue.  I would be good with either.


---

Reply via email to