Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r143553954
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyCLI.java
---
@@ -285,7 +285,14 @@ public static Options getOptions() {
}
private static CommandLine parse(Options options, String[] args) {
- CommandLineParser parser = new PosixParser();
+ CommandLineParser parser = new PosixParser() {
+ @Override
+ protected void processOption(String arg, ListIterator iter) throws
ParseException {
--- End diff --
Ah, yes, so this does bear a comment. Not sure if it requires a code
comment or not, but the general gist is that in order to pass args to `storm
jar` (in this case storm configs to override the transformation class), we have
to disregard options that we don't know about in the CLI. Storm will ignore
our args, we have to do the same. Do you think that should be a code comment?
---
