Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/787#discussion_r143735130
  
    --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts 
---
    @@ -32,13 +33,31 @@ export class UpdateService {
     
       defaultHeaders = {'Content-Type': 'application/json', 
'X-Requested-With': 'XMLHttpRequest'};
     
    +  alertChangedSource = new Subject<PatchRequest>();
    +  alertChanged$ = this.alertChangedSource.asObservable();
     
       constructor(private http: Http) { }
     
       public patch(patchRequest: PatchRequest): Observable<{}> {
         let url = '/api/v1/update/patch';
    -    return this.http.patch(url, patchRequest, new RequestOptions({headers: 
new Headers(this.defaultHeaders)}))
    -    .catch(HttpUtil.handleError);
    +    let observable = Observable.create((observer => {
    --- End diff --
    
    Would the alertChangedSource call be more appropriate in a map function?  
This seems like an awkward way to achieve this.  Or am I missing something?


---

Reply via email to