Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/799#discussion_r144896412
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
@@ -232,3 +241,48 @@ def set_hbase_acls(self):
Logger.info("Done setting HBase ACLs")
self.set_hbase_acl_configured()
+
+ def service_check(self, env):
+ """
+ Performs a service check for Enrichment.
+ :param env: Environment
+ """
+ Logger.info("Checking for Geo database")
+ metron_service.check_hdfs_file_exists(self.__params,
self.__params.geoip_hdfs_dir + "/GeoLite2-City.mmdb.gz")
--- End diff --
Yeah, we just have the HDFS directory, which is what you're using. For
this PR, I think it's good. I'd hate to make the perfect the enemy of the good.
Going forward, what would be cool is if we could execute a stellar script
via the REPL and if it fails, fail the service check. Since the REPL can
interact with global config parameters and has the capability to validate HDFS,
that would be a clean way to do this.
---
