Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147543792
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -67,6 +67,10 @@ ELSE : 'ELSE' | 'else';
NULL : 'null' | 'NULL';
NAN : 'NaN';
+AS : 'as' | 'AS';
--- End diff --
I know this may be fairly unlikely, but technically this is a breaking
change for Stellar. I believe if anyone had a variable called `as`, `AS`,
`etc.` it would fail with a parse exception. I think we should explicitly call
this out. Also, is this something we technically have to wait for a major
version release to add?
---
