GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/830
METRON-1298: TimeRange Picker doesn't work on Safari
## Contributor Comments
The Time Range component is not working in mac Safri b'coz of the way
Safari handles string to date conversions more details about what is wrong with
safari is
[here](https://stackoverflow.com/questions/4310953/invalid-date-in-safari). Also
- Took this oppurtunity to correct typos in a method and in a variable
name.
- I added a better waiting strategy for getting values in scrollToDashRow
and clickTableText methods. From my experence i feel the new way is much more
efficent than the way i was trying to get the values till now.
- Extracted the string 'now' to constant since it is used in multiple places
## Testing
- Open the Alert UI in safari and select on Date Picker
- Select date from Quick Ranges or Time Range, the From and To Date are not
populated and the rest call fails
- Apply the current PR and repeate the above two steps
- You see that the GUI works as expected the Data Range is populated and
the rest api would fetch all the results
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iraghumitra/incubator-metron METRON-1298
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/830.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #830
----
commit f7808edfd74d0790b46a4eccbfc6b067ed5aa4d7
Author: iraghumitra <raghumitra....@gmail.com>
Date: 2017-11-06T13:05:37Z
Fetching Date Obj from moment instead of using string representation
Removed the redundant method for alert title
Corrected the typo in method name and in constant name
Extracted 'now' string to a constant
Using better assertions for scrollToDashRow and clickTableText
commit f2f16895e69f094ff73bbe7bd0605878fa43dce9
Author: iraghumitra <raghumitra....@gmail.com>
Date: 2017-11-06T14:19:45Z
Removed all the occurrences of converting date str to date obj
----
---
