Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/827#discussion_r149162723
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -236,17 +236,14 @@ public void test() throws Exception {
.andExpect(jsonPath("$.groupResults[0].groupResults[0].score").value(50));
this.mockMvc.perform(post(searchUrl +
"/column/metadata").with(httpBasic(user,
password)).with(csrf()).contentType(MediaType.parseMediaType("application/json;charset=UTF-8")).content("[\"bro\",\"snort\"]"))
- .andExpect(status().isOk())
-
.andExpect(content().contentType(MediaType.parseMediaType("application/json;charset=UTF-8")))
- .andExpect(jsonPath("$.*", hasSize(2)))
-
.andExpect(jsonPath("$.bro.common_string_field").value("string"))
-
.andExpect(jsonPath("$.bro.common_integer_field").value("integer"))
- .andExpect(jsonPath("$.bro.bro_field").value("boolean"))
- .andExpect(jsonPath("$.bro.duplicate_field").value("date"))
-
.andExpect(jsonPath("$.snort.common_string_field").value("string"))
-
.andExpect(jsonPath("$.snort.common_integer_field").value("integer"))
- .andExpect(jsonPath("$.snort.snort_field").value("double"))
- .andExpect(jsonPath("$.snort.duplicate_field").value("long"));
+ .andExpect(status().isOk())
--- End diff --
And I should add, you did update the `SearchIntegrationTest` to test your
changes to `ElasticsearchDAO`. So I am happy with the level of testing you
have.
The test changes here really only test the `InMemoryDao`, I think. I find
the purpose of some of the tests here slightly confusing because they are not
really testing the `ElasticsearchDAO`, but that is a side issue that doesn't
matter all that much.
---
