Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/831#discussion_r151190210
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
 ---
    @@ -162,34 +164,77 @@ def start_indexing_topology(self, env):
                                           self.__params.metron_principal_name,
                                           
execute_user=self.__params.metron_user)
     
    -            start_cmd_template = 
"""{0}/bin/start_elasticsearch_topology.sh \
    -                                        -s {1} \
    -                                        -z {2}"""
    -            start_cmd = 
start_cmd_template.format(self.__params.metron_home,
    -                                                  self.__indexing_topology,
    -                                                  
self.__params.zookeeper_quorum)
    +            start_cmd_template = """{0}/bin/start_hdfs_topology.sh"""
    +            start_cmd = 
start_cmd_template.format(self.__params.metron_home)
                 Execute(start_cmd, user=self.__params.metron_user, tries=3, 
try_sleep=5, logoutput=True)
     
             else:
    -            Logger.info('Indexing topology already running')
    +            Logger.info('Batch Indexing topology already running')
     
    -        Logger.info('Finished starting indexing topology')
    +        Logger.info('Finished starting batch indexing topology')
     
    -    def stop_indexing_topology(self, env):
    -        Logger.info('Stopping ' + self.__indexing_topology)
    +    def start_random_access_indexing_topology(self, env):
    +        Logger.info('Starting ' + self.__random_access_indexing_topology)
    --- End diff --
    
    Definitely, @nickwallen I think we're thinking the same thing.  This is 
literally just the first baby step toward a broader vision of pluggable 
writers.  I think we probably want to start here with a discuss thread.  Where 
I was thinking of going next in here was merging the flux files into one and 
pulling the configs from zookeeper, which would be a step towards your vision.


---

Reply via email to