Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151794206
--- Diff: scripts/init.bro ---
@@ -18,11 +18,20 @@
module Kafka;
export {
- const topic_name: string = "bro" &redef;
- const max_wait_on_shutdown: count = 3000 &redef;
- const tag_json: bool = F &redef;
- const kafka_conf: table[string] of string = table(
- ["metadata.broker.list"] = "localhost:9092"
- ) &redef;
- const debug: string = "" &redef;
+ ## Destination kafka topic name
+ const topic_name: string = "bro" &redef;
+
+ ## Maximum wait on shutdown in milliseconds
+ const max_wait_on_shutdown: count = 3000 &redef;
+
+ ## Boolean to JSON with a log stream identifier
--- End diff --
Thanks for adding all the comments. But this one doesn't read so well.
Or maybe I just don't read so well. :) Read this one over once more. If it
still makes sense to you, then I'm good with it.
---
