Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153324714
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
+# C++ compiler
+echo "--"
+echo "g++"
+g++ --version
+
+# C++11 compliant compiler
+echo "--"
+OBJFILE=/tmp/test
+CPPFILE=/tmp/test.cpp
+cat > $CPPFILE <<- EOM
+#include <iostream>
+using namespace std;
+int main() {
+ cout << "Hello World!" << endl;
+ return 0;
+}
+EOM
+g++ -std=c++11 $CPPFILE -o $OBJFILE
+if [ $? -eq 0 ]; then
+ echo "Compiler is C++11 compliant"
+else
+ echo "Warning: Compiler is NOT C++11 compliant"
+fi
+rm -f $CPPFILE $OBJFILE
--- End diff --
> Do we have to account for platform_info on a non-dev machine? If there is
no g++ at all?
The platform-info script is there to tell us whether a machine can be used
to deploy metron. Right now, you have to build Metron to deploy it, so the
script checks all dev dependencies.
If g++ is not in the path, then the script will tell us that. And it would
carry on its merry way. That's the behavior that I would expect.
Maybe I am not following you. Can you describe the scenario you are
thinking of more?
---
