GitHub user jasper-k reopened a pull request:
https://github.com/apache/metron/pull/823
METRON-1286 Add MIN & MAX Stellar functions
## Contributor Comments
Currently Stellar lacks straightforward MAX & MIN functions that take just
a list of values as input.
The functions STATS_MAX and STATS_MIN only take the internal Stellar
statistics object as input.
Having MAX and MIN will be easier and understandable to most users
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasper-k/metron-apache master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit 50b3335b9699ed0bbed78e8ca37e3b8f639a7e0c
Author: jknulst <[email protected]>
Date: 2017-11-01T11:47:44Z
METRON-1286 Add MIN & MAX Stellar functions
commit eace1fec397a0297ee42fd59b8e824e1a34d9a90
Author: jknulst <[email protected]>
Date: 2017-11-14T07:37:36Z
METRON-1286 Min Max, added Apache header
commit f6e31c715caa91b71317b4338c98f3e6d37d3f2f
Author: jknulst <[email protected]>
Date: 2017-11-14T07:38:27Z
Merge branch 'master' of https://github.com/apache/metron
commit 9b596f45ee9b64adce29f32c0329f49efe5cf2c6
Author: jknulst <[email protected]>
Date: 2017-11-14T08:06:50Z
METRON-1286 Updated README.md
commit e606503e9a0d1c70b44e6098ab47e49b219c0410
Author: jknulst <[email protected]>
Date: 2017-11-29T19:38:12Z
Merge branch 'master' of https://github.com/apache/metron
commit 9410526274722f2ccdcded94a9ddadcf742defb4
Author: cstella <[email protected]>
Date: 2017-11-29T20:52:16Z
Updating functions and test.
commit a4c6d2b3599456c33a8dd2c228886b59af622868
Author: cstella <[email protected]>
Date: 2017-11-29T21:15:15Z
Whoops, fixed a subtle bug.
commit 08cc087daaa173c9ab7f3aaab9f64b34807b5c5a
Author: cstella <[email protected]>
Date: 2017-11-29T21:19:06Z
Missed an iterable
commit 6ef4ecfa035b68339e754c4d77fff743142cd66d
Author: jknulst <[email protected]>
Date: 2017-11-29T21:23:34Z
Simplified code and added extra test
commit 041ed595712e885eeb4d8bc5679a4e9f3063121e
Author: cstella <[email protected]>
Date: 2017-11-29T21:36:27Z
Merge remote-tracking branch 'jasper/master' into jasperminmax-ex
commit aa95db0f88f53875d8b9ebd61793afa06db3ede0
Author: jasper-k <[email protected]>
Date: 2017-11-29T21:39:03Z
Merge pull request #1 from cestella/jasperminmax-ex
Updating OrdinalFunctions to be more tolerant of mixed lists and be O(n)
commit 3a95d2ac44815d6e603524a3b99787ca969133e6
Author: jknulst <[email protected]>
Date: 2017-11-29T21:55:41Z
Added test for Set input
commit dc784e41310740dbc4afe8e666e62f94a18b5ba4
Author: jknulst <[email protected]>
Date: 2017-11-29T22:58:20Z
Refactored MIN / MAX function descriptions
commit fcd7a4186325e1b4dad999ce509acb3b0f210c5a
Author: jknulst <[email protected]>
Date: 2017-11-30T09:08:48Z
Aligned function description on annotation and README.md, added examples
----
---
