Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/851#discussion_r154207865
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
 ---
    @@ -156,7 +156,7 @@ public static void 
writeConfigToZookeeper(ConfigurationType configType,Optional<
       }
     
       private static String getConfigZKPath(ConfigurationType configType, 
Optional<String> configName) {
    -    String pathSuffix = configName.isPresent() && configType != GLOBAL ? 
"/" + configName : "";
    +    String pathSuffix = configName.isPresent() && configType != GLOBAL ? 
"/" + configName.get() : "";
    --- End diff --
    
    I think that's because we handle global config in a special way. This whole 
class needs refactored, and I'd have done more with the original patch PR had 
it not blown up scope.


---

Reply via email to