Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154761355
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42 @@ public static void uploadConfigsToZookeeper(String
rootFilePath, CuratorFramewor
* @param type config type to upload configs for
* @param configName specific config under the specified config type
*/
- public static void uploadConfigsToZookeeper(String rootFilePath,
CuratorFramework client,
- ConfigurationType type, Optional<String> configName) throws
Exception {
+ public static void uploadConfigsToZookeeper(
+ String rootFilePath,
--- End diff --
When reading from file, the API should explicitly require file Paths as
opposed to just strings.
It makes the api methods easier to understand when there are a bunch of
similar methods.
---
