Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/840
  
    I don't think that's a bad idea. I definitely like having test scripts 
associated with the PR's because we can explicitly see what was done and/or 
recommended at the time the PR was being ushered into master. But we could also 
start to consolidate these into manual testing scripts that we reference 
ongoing. Then you could say something like:
    
    ```
    Testing Plan
    - es basic search test
    - meta alerts search test
    - kibana dashboard smoke test
    ```
    
    That could be links, or we could copy-paste the current manual test plan 
from the source tree. I think the main thing I would want is to have the PR's 
test plan (here in the comments) be maintained statically for posterity based 
on the code at that time. For example, since we're removing the data pruner, 
the new test plan would not have a data pruner test, but I'd want to make sure 
any earlier PRs that did have a test plan for it can still be viewed 
statically. Basically, you'd either include the latest commit as part of the 
link or copy-paste the test plan. 


---

Reply via email to