GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/886
METRON-1385: Missing "properties" in index template causes
ElasticsearchColumnMetadataDao.getColumnMetadata to fail
## Contributor Comments
A bug was recently discovered that causes a NPE when calling
ElasticsearchColumnMetadataDao.getColumnMetadata to get ES column types. It
can be recreated by adding a template to ES that matches all indices and also
contains a doc type mapping without the "properties" property. For example:
```
curl -XPUT 'http://node1:9200/_template/default_string_template' -d '
{
"template": "*",
"mappings" : {
"bro_type": {
"dynamic_templates": [
{
"strings": {
"match_mapping_type": "string",
"mapping": {
"type": "text"
}
}
}
]
}
}
}
```
A NPE should now happen when calling the REST endpoint to get column
metadata for bro.
This PR fixes that bug by first checking to see if the "properties"
property exists and continuing on if it does not. I also added an additional
mapping in ElasticsearchSearchIntegrationTest that mimics this condition.
Happy to remove it if people feel it's unnecessary.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1385
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #886
----
commit 8905d4d21926ac4e518d14fb0b4b44fbf4dea158
Author: merrimanr <merrimanr@...>
Date: 2018-01-02T16:22:12Z
initial commit
----
---
