GitHub user mmiklavc opened a pull request:

    https://github.com/apache/metron/pull/906

    1426: SensorIndexingConfigControllerIntegrationTest fails intermittently

    ## Contributor Comments
    
    https://issues.apache.org/jira/browse/METRON-1426
    
    Sensor indexing config has a race condition with ZK cache. A similar fix 
has been made before, but there remained a few test assertions that still 
potentially had this issue - https://github.com/apache/metron/pull/795
    
    ## Testing
    
    Run mvn clean install and verify tests pass. Also, Travis should pass more 
than once.
    
    **Side note:** As of submission, there appears to be separate Travis 
infrastructure issues that are causing timeouts. Will update as new info is 
available.
    
    ## Pull Request Checklist
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes? 
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mmiklavc/metron fix-test-fail

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #906
    
----
commit bf5f251118875945fb372d6393e492fc94389821
Author: Michael Miklavcic <michael.miklavcic@...>
Date:   2018-01-24T15:07:43Z

    Sensor indexing config has a race condition with ZK cache

----


---

Reply via email to