GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/908
1428: Travis build failing from metron-config
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1428
Travis is failing because of npm downstream package problems. The chain of
dependencies went like this: karma-remap-istanbul ^0.2.1 -> remap-istanbul some
version or another -> source-map ver 7.0.0. The problem came with an api change
of sorts to source-map. remap-istanbul has made a patch version in 0.9.6 to fix
the dependency, and in order to get the proper remap-istanbul version that
limits the pool of source-map versions, I had to upgrade karma-remap-istanbul
to 0.6.0. This fixed the chain of dependencies without seemingly breaking
anything else along the way, thankfully.
I have to look at what we do with the UI libraries for licensing reporting,
as I currently have no idea yet what that looks like, so I'll update that
shortly. For now, I wanted to see if this gets the build working, at the very
least.
## Pull Request Checklist
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron metron-config-lib-conflict
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #908
----
commit bc8dcc4eb5e1b5863c165be295647b2bcbbbd852
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-01-24T17:17:30Z
Update karma-remap-istanbul to fix source-map downstream dependency problem
----
---
