Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/922#discussion_r165548986
  
    --- Diff: 
metron-platform/metron-solr/src/test/java/org/apache/metron/solr/schema/SchemaTranslatorTest.java
 ---
    @@ -0,0 +1,188 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.solr.schema;
    +
    +import com.google.common.base.Splitter;
    +import com.google.common.collect.Iterables;
    +import org.adrianwalker.multilinestring.Multiline;
    +import org.apache.metron.common.configuration.writer.WriterConfiguration;
    +import org.apache.metron.common.utils.JSONUtils;
    +import org.apache.metron.integration.UnableToStartException;
    +import org.apache.metron.solr.integration.components.SolrComponent;
    +import org.apache.metron.solr.writer.SolrWriter;
    +import org.json.simple.JSONObject;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.io.IOException;
    +import java.io.PrintWriter;
    +import java.io.StringWriter;
    +import java.util.*;
    +
    --- End diff --
    
    Shouldn't this be an integration test?


---

Reply via email to