GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/948
METRON-1468: Add support for apache/metron-bro-plugin-kafka to
prepare-commit
## Contributor Comments
This updates the prepare-commit script to work with
`apache/metron-bro-plugin-kafka`.
To test, run the `prepare-commit` script and specify `metron`, `bro`, or
blank when it asks for which repo. It should use metron by default, but
properly accounts for the bro repo if you specify it.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [N/A] Have you written or updated unit tests and or integration tests to
verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [N/A] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/metron METRON-1468
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/948.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #948
----
commit 4ca17d5780729a61615e7ee6bc86e6ddf86c339e
Author: Nick Allen <nick@...>
Date: 2017-11-27T20:29:38Z
METRON-1320 Cannot perform a bare-metal installation
commit b64606997307e233a4ef9741c2ad16e622eac952
Author: Nick Allen <nick@...>
Date: 2017-11-27T20:55:12Z
Cleaning up after the C++ file(s) that we create
commit 551e3084c60346a6459101994043afa84869ab61
Author: Jon Zeolla <zeolla@...>
Date: 2017-11-29T02:03:54Z
Merge branch 'METRON-1320' of https://github.com/nickwallen/metron into
METRON-1320
commit 1040681a59907fdedf8784bf19fc025cc9125b1c
Author: Jon Zeolla <zeolla@...>
Date: 2017-12-05T12:56:40Z
Merge branch 'master' of https://github.com/apache/metron
commit e916d3dcbeb744a426559d7e7e47695ebd37748b
Author: Jon Zeolla <zeolla@...>
Date: 2017-12-06T14:00:51Z
Merge branch 'master' of https://github.com/apache/metron
commit a7b5bdfd5652035beb38aed52fd4e1e12e680439
Author: Jon Zeolla <zeolla@...>
Date: 2017-12-07T20:14:46Z
Merge branch 'master' of https://github.com/apache/metron
commit f9af29979385877b90f7940561382c722404eff8
Author: Jon Zeolla <zeolla@...>
Date: 2017-12-08T14:22:24Z
Merge branch 'master' of https://github.com/apache/metron
commit 5c6dc76d9fbdb58274171446bc75800a42466ba2
Author: Jon Zeolla <zeolla@...>
Date: 2017-12-27T12:34:43Z
Merge branch 'master' of https://github.com/apache/metron
commit 4d52410120830ea0586b54fb2c85fdefc0a8444d
Author: Jon Zeolla <zeolla@...>
Date: 2018-03-05T17:57:47Z
Merge branch 'master' of https://github.com/jonzeolla/metron
commit 60044f0b05297f404bd7c79bbdd280a5b8a7a6de
Author: Jon Zeolla <zeolla@...>
Date: 2018-03-05T18:14:40Z
METRON-1468: Add support for apache/metron-bro-plugin-kafka to
prepare-commit
commit 0c88d182d4b4a2a1db9b694742eb3b7d4f0f7ad5
Author: Jon Zeolla <zeolla@...>
Date: 2018-03-05T18:34:43Z
Update readme
----
---
