Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174468438
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.performance.load;
+
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.apache.kafka.clients.producer.ProducerRecord;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.TimerTask;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+public class SendToKafka extends TimerTask {
--- End diff --
To expand on the reasoning for just making it SendToKafka<K, V>, right now
it's using raw KafkaProducer, with one exception. Since we already know the
types, we can make it KafkaProducer<String, String> in the arguments. I think
we shouldn't leave it raw, because passing in a different KafkaProducer is
going to be incorrect the exception at line 71:
`KafkaProducer<String, String> producer = kafkaProducer.get();`.
I definitely don't think making the whole thing pluggable is worth doing
now but making the KafkaProducer's all <String, String> for correctness vs just
making the class <K, V> is basically the same amount of effort.
---
