Thanks for the hard work on that upgrade and this very useful highlight reel.
On Sat, Dec 7, 2019, 10:17 AM Justin Leet <justinjl...@gmail.com> wrote: > Hi all, > > The JUnit 5 migration PR has been merged to master. From this point > forward, please use the newer interfaces and methods. There are plenty of > examples through the code, and for more information, check out see > https://junit.org/junit5/. > > Brief list of things to be aware of when writing JUnit 5 tests: > > - Generally, use org.junit.jupiter.api imports. > - There are some minor interface changes, e.g. @BeforeAll > replaces @BeforeClass > - Failure messages are now at the end of the argument list. > - Exception checking idiom has been improved with JUnit 5. Please see an > example at UpdateDaoTest.java#L60 > < > https://github.com/apache/metron/blob/b71ddceeefb4efc677f800c66ca65fae46f4a45a/metron-platform/metron-indexing/metron-indexing-common/src/test/java/org/apache/metron/indexing/dao/UpdateDaoTest.java#L60 > > > . > - Parameterized tests function differently now. Please see an example at > ByteArrayMatchingUtilTest.java#L85 > < > https://github.com/apache/metron/blob/b71ddceeefb4efc677f800c66ca65fae46f4a45a/metron-platform/metron-pcap/src/test/java/org/apache/metron/pcap/pattern/ByteArrayMatchingUtilTest.java#L85 > > > . > - No more PowerMock. Please reconsider your code design if you need to > mock a static classes. > - The replacement for @TemporaryFolder is still experimental, and as > such has generally stayed. @EnableRuleMigrationSupport at the class > level > allows this to continue, as @Rule is generally no longer used. > > > Thanks! >
