Thanks a lot Ryan for refactoring to include the original pull request. I really appreciate you taking the time to do that. I will carve out some time this week to go through the new code and test it.
On 1/26/16, 1:32 PM, "Ryan Merriman" <rmerri...@hortonworks.com> wrote: >Here is the new pull request with the modifications: > >https://github.com/apache/incubator-metron/pull/15 > > >This only includes the additions our team contributed since METRON-2. > >On 1/26/16, 8:39 AM, "Ryan Merriman" <rmerri...@hortonworks.com> wrote: > >>Mark, >> >>We went back and merged METRON-2 into the master branch so your pull >>request is in the commit history now. Let me know if something doesn’t >>look right. I am going to add the most recent deployment changes on top >>of that and submit a new pull request. We would love your feedback since >>you are experienced with Ansible. >> >> >>Sorry for the misunderstanding. Some of us are new to this process and >>the fact that your pull request didn’t get merged before the big refactor >>tripped us up. >> >>Ryan Merriman >> >>On 1/25/16, 8:54 PM, "Ryan Merriman" <rmerri...@hortonworks.com> wrote: >> >>>Really sorry about that Mark. I was so focused on getting everything >>>working that I wasn¹t thinking about the commit history. I will get that >>>fixed. I promise it wasn¹t intentional. >>> >>>On 1/25/16, 8:27 PM, "Mark Bittmann" <m...@b23.io> wrote: >>> >>>>Ryan, >>>> >>>>It looks like you took all the code from PR #3 resubmitted it as your >>>>own >>>>in PR #14. Obviously you put in a ton of extra work on top of it, and >>>>I'm >>>>excited to see you build off of it, but I would be personally >>>>disappointed to not get any credit for laying the foundation for all of >>>>the Hadoop components. >>>> >>>>https://github.com/apache/incubator-metron/pull/3 >>>> >>>>I would think it would be better for the community to have multiple >>>>people contributing incrementally. Wouldn't it make more sense to pull >>>>in >>>>PR #3 rather than copying the code into a new PR and losing the history? >>>> >>>>Mark >>>> >>>> >>>> >>>> >>>> >>>> >>>>On 1/25/16, 8:38 PM, "merrimanr" <g...@git.apache.org> wrote: >>>> >>>>>Github user merrimanr commented on the pull request: >>>>> >>>>> >>>>>https://github.com/apache/incubator-metron/pull/14#issuecomment-1747614 >>>>>3 >>>>>3 >>>>> >>>>> https://issues.apache.org/jira/browse/METRON-21 >>>>> >>>>> >>>>>--- >>>>>If your project is set up for it, you can reply to this email and have >>>>>your >>>>>reply appear on GitHub as well. If your project does not have this >>>>>feature >>>>>enabled and wishes so, or if the feature is enabled but not working, >>>>>please >>>>>contact infrastructure at infrastruct...@apache.org or file a JIRA >>>>>ticket >>>>>with INFRA. >>>>>--- >>> >>> >> >
