Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/81#discussion_r60249308
--- Diff:
metron-streaming/Metron-Common/src/test/java/org/apache/metron/bolt/BulkMessageWriterTest.java
---
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.bolt;
+
+import backtype.storm.tuple.Tuple;
+import backtype.storm.tuple.Values;
+import org.adrianwalker.multilinestring.Multiline;
+import org.apache.metron.Constants;
+import org.apache.metron.domain.Configurations;
+import org.apache.metron.writer.interfaces.BulkMessageWriter;
+import org.hamcrest.Description;
+import org.json.simple.JSONObject;
+import org.json.simple.parser.JSONParser;
+import org.json.simple.parser.ParseException;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.ArgumentMatcher;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+
+import java.io.FileInputStream;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.Assert.fail;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class BulkMessageWriterTest extends BaseEnrichmentBoltTest {
+
+ protected class MessageListMatcher extends
ArgumentMatcher<List<JSONObject>> {
+
+ private List<JSONObject> expectedMessageList;
+
+ public MessageListMatcher(List<JSONObject> expectedMessageList) {
+ this.expectedMessageList = expectedMessageList;
+ }
+
+ @Override
+ public boolean matches(Object o) {
+ List<JSONObject> actualMessageList = (List<JSONObject>) o;
+ for(JSONObject message: actualMessageList)
removeTimingFields(message);
+ return expectedMessageList.equals(actualMessageList);
+ }
+
+ @Override
+ public void describeTo(Description description) {
+ description.appendText(String.format("[%s]", expectedMessageList));
+ }
+
+ }
+
+ /**
+ * {
+ * "field": "value",
+ * "source.type": "yaf"
+ * }
+ */
+ @Multiline
+ private String sampleMessageString;
+
+ private JSONObject sampleMessage;
+ private List<JSONObject> messageList;
+ private List<Tuple> tupleList;
+
+ @Before
+ public void parseMessages() throws ParseException {
+ JSONParser parser = new JSONParser();
+ sampleMessage = (JSONObject) parser.parse(sampleMessageString);
+ sampleMessage.put("field", "value1");
+ messageList = new ArrayList<>();
+ messageList.add(((JSONObject) sampleMessage.clone()));
+ sampleMessage.put("field", "value2");
+ messageList.add(((JSONObject) sampleMessage.clone()));
+ sampleMessage.put("field", "value3");
+ messageList.add(((JSONObject) sampleMessage.clone()));
+ sampleMessage.put("field", "value4");
+ messageList.add(((JSONObject) sampleMessage.clone()));
+ sampleMessage.put("field", "value5");
+ messageList.add(((JSONObject) sampleMessage.clone()));
+ }
+
+ @Mock
+ private BulkMessageWriter<JSONObject> bulkMessageWriter;
+
+ @Test
+ public void test() throws Exception {
+ BulkMessageWriterBolt bulkMessageWriterBolt = new
BulkMessageWriterBolt("zookeeperUrl").withBulkMessageWriter(bulkMessageWriter);
+ bulkMessageWriterBolt.setCuratorFramework(client);
+ bulkMessageWriterBolt.setTreeCache(cache);
+
bulkMessageWriterBolt.configurations.updateSensorEnrichmentConfig(sensorType,
new FileInputStream(sampleSensorEnrichmentConfigPath));
+ bulkMessageWriterBolt.declareOutputFields(declarer);
+ verify(declarer, times(1)).declareStream(eq("error"), argThat(new
FieldsMatcher("message")));
+ Map stormConf = new HashMap();
+ doThrow(new Exception()).when(bulkMessageWriter).init(eq(stormConf),
any(Configurations.class));
+ try {
+ bulkMessageWriterBolt.prepare(stormConf, topologyContext,
outputCollector);
+ fail("A runtime exception should be thrown when
bulkMessageWriter.init throws an exception");
+ } catch(RuntimeException e) {}
+ reset(bulkMessageWriter);
+ bulkMessageWriterBolt.prepare(stormConf, topologyContext,
outputCollector);
+ verify(bulkMessageWriter, times(1)).init(eq(stormConf),
any(Configurations.class));
+ tupleList = new ArrayList<>();
+ for(int i = 0; i < 4; i++) {
+
when(tuple.getValueByField("message")).thenReturn(messageList.get(i));
+ tupleList.add(tuple);
+ bulkMessageWriterBolt.execute(tuple);
+ verify(bulkMessageWriter, times(0)).write(eq(sensorType),
any(Configurations.class), eq(tupleList), eq(messageList));
+ }
+ when(tuple.getValueByField("message")).thenReturn(messageList.get(4));
+ tupleList.add(tuple);
+ bulkMessageWriterBolt.execute(tuple);
+ verify(bulkMessageWriter, times(1)).write(eq(sensorType),
any(Configurations.class), eq(tupleList), argThat(new
MessageListMatcher(messageList)));
+ verify(outputCollector, times(5)).ack(tuple);
+ reset(outputCollector);
+ doThrow(new Exception()).when(bulkMessageWriter).write(eq(sensorType),
any(Configurations.class), Matchers.anyListOf(Tuple.class),
Matchers.anyListOf(JSONObject.class));
+ when(tuple.getValueByField("message")).thenReturn(messageList.get(0));
+ for(int i = 0; i < 5; i++) bulkMessageWriterBolt.execute(tuple);
--- End diff --
This is a style thing, but can we please have braces? It's so easy to
accidentally screw if's and for's up without explicit braces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
