Github user james-sirota commented on the pull request:
https://github.com/apache/incubator-metron/pull/138#issuecomment-222347328
I spot checked the validators and the validators work. I checked IP,
domain, url and date using YAF and Bro. I did not test the negative case since
the dead letter q does not yet exist. One thing of note I see that you are
using commons validator and in my previous experience this library has pretty
significant performance issues validating IPs. I think checking it with regex
was 10 times faster or something around there. Once we get to performance
tuning this may be something to keep in mind. Otherwise great job! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
