Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/144#discussion_r66055523
--- Diff: metron-deployment/roles/metron_streaming/tasks/main.yml ---
@@ -15,25 +15,18 @@
# limitations under the License.
#
---
-- name: Create Metron streaming directories
- file: path="{{ metron_directory }}/{{ item.name }}" state=directory
mode=0755
+- name: Create Metron directories
+ file: path={{ metron_directory }}/{{ item }} state=directory mode=0755
with_items:
- - { name: 'lib'}
- - { name: 'bin'}
- - { name: 'config'}
+ - lib
+ - bin
+ - config
- name: Create Source Config Directory
- file:
- path: "{{ zookeeper_config_path }}"
- state: directory
- mode: 0755
+ file: path={{ zookeeper_config_path }} state=directory mode=0755
--- End diff --
More compact. To my eyes it reads better with the other single-line code
lines around it. Purely aesthetic. Can undo if there is an objection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
