GitHub user mmiklavc opened a pull request:
https://github.com/apache/incubator-metron/pull/296
METRON-439: Stellar : IS_EMPTY(host) throws exception
Fix Stellar IS_EMPTY validation to handle empty and null
Addresses https://issues.apache.org/jira/browse/METRON-439
Things have changed a bit since the original Jira was filed. Most notably,
this error appears while dumping config from Zookeeper after it has already
been loaded. The current functionality/validation would not have allowed the
load to succeed in the first place. Even so, empty and null checks could be
handled more gracefully. This PR changes IS_EMPTY to return true on null or
empty string rather than throw an exception.
Added new unit tests and validated on quick-dev with multiple bro messages
- normal host, empty host string, and null/non-existent host string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/incubator-metron METRON-439
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit bd6e1a5cc48962af36b131e189ffb461e836cd20
Author: Michael Miklavcic <michael.miklav...@gmail.com>
Date: 2016-10-06T17:09:14Z
METRON-439: Fix Stellar IS_EMPTY validation to handle empty and null
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
