Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83338244
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java
---
@@ -34,15 +34,15 @@
* @param rawMessage
* @return If null is returned, this is treated as an empty list.
*/
- List<T> parse(byte[] rawMessage);
+ List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
--- End diff --
I agree with @mattf-horton 's concerns here. It is not ideal to change the
interface.
The GrokParser is a Configurable and so it has a configure method. Can we
use the configure method to pass through the necessary grok configuration?
The ParserBolt already calls parser.configure(...) in ParserBolt.prepare.
Can we have the ParserBolt.execute call parser.configure(...) anytime the
configuration changes? Or even each time, if you like?
It seems the Configurable interface was created to pass through
configuration values, so it might be a bit cleaner this way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
