Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/401#discussion_r93530871
--- Diff:
metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java
---
@@ -356,6 +357,44 @@ public void testSkewness() throws Exception {
assertEquals(stats.getSkewness(), (Double) actual, 0.1);
}
+ @Test
+ public void testStatsBin() throws Exception {
+ statsInit(windowSize);
+
statsBinRunner(StellarStatisticsFunctions.Bin.BinSplits.QUARTILE.split);
+
statsBinRunner(StellarStatisticsFunctions.Bin.BinSplits.QUARTILE.split,
"'QUARTILE'");
+
statsBinRunner(StellarStatisticsFunctions.Bin.BinSplits.QUINTILE.split,
"'QUINTILE'");
+ statsBinRunner(StellarStatisticsFunctions.Bin.BinSplits.DECILE.split,
"'DECILE'");
+ statsBinRunner(ImmutableList.of(25.0, 50.0, 75.0), "[25.0, 50.0,
75.0]");
+ }
+
+ public void statsBinRunner(List<Double> splits) throws Exception {
+ statsBinRunner(splits, null);
+ }
+
+ public void statsBinRunner(List<Double> splits, String splitsName)
throws Exception {
+ int bin = 0;
+ for(Double d : stats.getSortedValues()) {
+ StatisticsProvider provider =
(StatisticsProvider)variables.get("stats");
+ if(bin < splits.size()) {
+ double percentileOfBin = provider.getPercentile(splits.get(bin));
+ if (d > percentileOfBin) {
--- End diff --
Sorry if I'm wrong here, but I couldn't find the definition of
stats.getSortedValues().
Isn't this line 380 comparing a raw value `d` to a percentile value
`percentileOfBin` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---