Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/401#discussion_r95371355
  
    --- Diff: 
metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java
 ---
    @@ -356,6 +357,49 @@ public void testSkewness() throws Exception {
         assertEquals(stats.getSkewness(), (Double) actual, 0.1);
       }
     
    +  @Test
    +  public void testStatsBin() throws Exception {
    --- End diff --
    
    This test is testing that the `STATS_BIN` function operates correctly by 
taking a sorted list of numbers, walking down it and ensuring that the 
`STATS_BIN` for each number yields the correct bin.  This is a reasonable test 
because we are not actually computing the bin so much as recognizing since the 
numbers are sorted, the bin will increase at the percentile boundaries, thus we 
have the expected bin without recreating the computation in the `STATS_BIN` 
function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to