Github user mmiklavc commented on the issue:
https://github.com/apache/incubator-metron/pull/417
@nickwallen Nice contribution! The docs are solid, and I like the
configurability of the batch size and frequency. And the quicker deploy time is
definitely a plus. Is that because we're no longer deploying the sensors by
default? I'm on the fence about how we should handle that. I originally thought
it best to deploy and not start the real sensors. But if we're saving 14
minutes in the Vagrant deployment, I could be convinced otherwise. And the more
I think about it, you could just run the Ansible role for the sensors which is
easy enough. I don't really have any other suggested changes besides the minor
remark above about the default of 100 vs 1000.
+1 from me pending the Travis checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
