Github user jjmeyer0 commented on the issue: https://github.com/apache/incubator-metron/pull/316 I've tested a few controllers (global config, grok controller, and kafka controller). Everything seems to be working pretty well. I will continue to test more, but since this is a large PR I wanted to do smaller chunks at a time. I think we should start thinking about is how we are going to architect the service layer. I'd like to discuss two things that I think will help us improve the maintainability of this. *Each service should implement an interface.** **We should discuss how to better break up services.** I think services should be conceptually simple. Mostly interact with a specific system. If we start getting into more complicated situations where multiple services are needed these should be in a separate area. I consider situations like these to be more of a service facade. A current example of this is with the `StormService`. I think the interactions with the storm API should be in its own service. Then a facade would be used with the storm service and other necessary services to give a simpler view into storm based on our context. Does this make sense? Personally I think number 1 should be done apart of this PR and number 2 should probably turn into a wider discussion. What do you all think? If others agree, I'd be glad to write up a Jira to discuss number 2.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---