Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/421#discussion_r97829967
  
    --- Diff: metron-platform/metron-data-management/README.md ---
    @@ -250,3 +250,18 @@ The parameters for the utility are as follows:
     | -l         | --log4j             | No           | The log4j properties 
file to load                                                                    
                                                                                
|
     | -n         | --enrichment_config | No           | The JSON document 
describing the enrichments to configure.  Unlike other loaders, this is run 
first if specified.                                                             
       |
     
    +### GeoLite2 Loader
    +
    +The shell script `$METRON_HOME/bin/geo_enrichment_load.sh` will retrieve 
MaxMind GeoLite2 data and load data into HDFS, and update the configuration.
    +
    +THIS SCRIPT WILL NOT UPDATE AMBARI'S GLOBAL.JSON, JUST THE ZK CONFIGS.  
CHANGES WILL GO INTO EFFECT, BUT WILL NOT PERSIST PAST AN AMBARI RESTART UNTIL 
UPDATED THERE.
    +
    --- End diff --
    
    This gets into the whole "How do we manage configs discussion?".  
Unfortunately, it's in a really awkward spot.  I might be able to add a service 
action to sorta take care of it, but it still probably does the same end around 
of Ambari's management, except it's going through the UI. I don't know that 
there's a good solution to this until we unify our config management, which is 
the real answer here.
    
    Given that I don't think there was originally support for updating the db, 
I'm inclined to clean it up as part of unifying config management.  It's ugly 
and I don't like it, but I can't come up with a good, short-term, alternative 
that isn't ugly for other reason anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to