> On Jan 26, 2017, at 9:19 PM, Otto Fowler <[email protected]> wrote: > > PR: https://github.com/apache/incubator-metron/pull/361 > > This is a valid PR for building on macs, but the submitter has not > responded to comments about changing PR title with the jira name. I would > very much like to land it, but I’m not sure how we want to proceed. > > Originally it did not have a jira, so I created one. > > How should this be handled? > > Should I create my own pr based on this one and to resolve the issue?
You are fine to do that IMO. The fact that the individual opened a pull request shows intention to contribute, so you can safely include that commit. However, I would advise against squashing it. It is important to retain authorship history. -Taylor
