Agreed, sounds good to me. I'm good with it getting merged. Jon
On Fri, Feb 3, 2017, 6:31 PM mattf-horton <[email protected]> wrote: > Github user mattf-horton commented on the issue: > > https://github.com/apache/incubator-metron/pull/429 > > Hi @JonZeolla , you have good eyes! I missed those cases, which are > only visible where H1 headers have been used in the *body* of the document, > AND there are TOC or other internal links to those headings. > > Eeesh, that's an unfortunate deficiency in the doxia-markdown plugin. > Apparently it does not generate named anchors for the H1 headers, perhaps > under the assumption there will only be one at the beginning of the doc? > At any rate, I've opened two new jiras: > - METRON-697 [site-book] doxia-markdown plugin doesn't generate named > anchors for H1 headings > METRON-698 [site-book] Add link checker as a "unit test" for site-book > build > > But I request that we allow these to be addressed as follow-on tasks, > so we can get the site-book as it is into the public's hands. Thanks. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- > -- Jon Sent from my mobile device
