Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/486#discussion_r107681982
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -106,19 +105,26 @@ public static TopologyBuilder build(String
zookeeperUrl,
/**
* Create a spout that consumes tuples from a Kafka topic.
*
- * @param zookeeperUrl Zookeeper URL
+ * @param zkQuorum Zookeeper URL
* @param sensorType Type of sensor
- * @param offset Kafka topic offset where the topology
will start; BEGINNING, END, WHERE_I_LEFT_OFF
- * @param kafkaSpoutConfigOptions Configuration options for the kafka
spout
+ * @param kafkaConfigOptional Configuration options for the kafka
spout
* @param parserConfig Configuration for the parser
* @return
*/
- private static KafkaSpout createKafkaSpout(String zookeeperUrl, String
sensorType, SpoutConfig.Offset offset, EnumMap<SpoutConfigOptions, Object>
kafkaSpoutConfigOptions, SensorParserConfig parserConfig) {
-
+ private static StormKafkaSpout createKafkaSpout(String zkQuorum, String
sensorType, Optional<Map<String, Object>> kafkaConfigOptional,
SensorParserConfig parserConfig) {
+ Map<String, Object> kafkaSpoutConfigOptions =
kafkaConfigOptional.orElse(new HashMap<>());
String inputTopic = parserConfig.getSensorTopic() != null ?
parserConfig.getSensorTopic() : sensorType;
- SpoutConfig spoutConfig = new SpoutConfig(new ZkHosts(zookeeperUrl),
inputTopic, "", inputTopic).from(offset);
- SpoutConfigOptions.configure(spoutConfig, kafkaSpoutConfigOptions);
- return new KafkaSpout(spoutConfig);
+
if(!kafkaSpoutConfigOptions.containsKey(SpoutConfiguration.FIRST_POLL_OFFSET_STRATEGY.key))
{
--- End diff --
Yep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
