GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/490
DO NOT MERGE METRON-797: Pass security.protocol and enable auto-renew for
the storm topologies
## Contributor Comments
METRON-793 migrated the storm topologies to the storm-kafka-client spout,
which supports kerberos. To complete the kerberos work on the existing
topologies, we need to be able to enable the spouts and kafka writers to use
security protocols other than PLAINTEXT. Also, enabling auto-renew plugins for
storm will enable the topologies to run for extended durations in a kerberized
cluster.
NOTE: This does not encompass MPack changes to enable kerberos or fix the
sensors to work with a kerberized kafka. That would be follow-on work.
NOTE: This depends on METRON-793. As such, this PR includes it, so do not
merge until 793 is merged.
An acceptance test plan will follow as well as instructions for kerberizing
vagrant and running the topologies in said environment.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
bin/generate-md.sh
mvn site:site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-797
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #490
----
commit 1a0dd8dafd7e722e9421cebe2f19fe540ccea73d
Author: cstella <ceste...@gmail.com>
Date: 2017-03-22T14:28:53Z
METRON-793: Migrate to storm-kafka-client kafka spout from storm-kafka
commit 9e2ff8aa7e6113d5aba89ba1c1b5eebb375ffd6d
Author: cstella <ceste...@gmail.com>
Date: 2017-03-22T14:35:48Z
Updating to remove commented out code.
commit 8a5100b5d9a3abdc464899055de3c0c86e4487d9
Author: cstella <ceste...@gmail.com>
Date: 2017-03-22T18:06:39Z
Better documentation
commit b6adf40ed7c5ce696d4e9ee7871fcd8bbdca9923
Author: cstella <ceste...@gmail.com>
Date: 2017-03-22T18:42:23Z
Adding for the spout configuration.
commit 49ccefb5435e6b5057fbba8c5b33f532dbad8904
Author: cstella <ceste...@gmail.com>
Date: 2017-03-22T18:47:10Z
Some test reuse.
commit 59b9eb7ba31d42b48041191569ef7a2cd51ce050
Author: cstella <ceste...@gmail.com>
Date: 2017-03-22T22:07:29Z
Adjusted kafkaUtils in the situation where the host and port aren't
available to pull from the endpoints.
commit aa298f81bfe3fae29c2cdfcd5477c1ce8af20209
Author: cstella <ceste...@gmail.com>
Date: 2017-03-23T14:48:11Z
Reacting to jleet's comments
commit 5d36c79effec75f6ac95fa587f80da0bd5420135
Author: cstella <ceste...@gmail.com>
Date: 2017-03-23T15:27:35Z
Migrated kafkautils to use URI
commit d065a9968351da5d801b92dbcf5c1ee5fe56a294
Author: cstella <ceste...@gmail.com>
Date: 2017-03-23T15:38:03Z
Whoops.
commit 90c48ede6f3455f4346aec4a4a5fcfa8ce3bd985
Author: cstella <ceste...@gmail.com>
Date: 2017-03-23T16:34:25Z
We are no longer using the kafka offsets as part of the cli. They are
moved into the kafka config.
commit 0c52e6fe71bbfef108f95944dc0a55434bd0ab1c
Author: cstella <ceste...@gmail.com>
Date: 2017-03-23T16:43:49Z
Whoops, missed test.
commit 11cf0401d1718d5949655d568c8bc0e032ff6302
Author: cstella <ceste...@gmail.com>
Date: 2017-03-23T21:36:14Z
Merge branch 'master' into METRON-793
commit 0ccd0e278c45cc80ee7cd19f3a107a5cd7a69dfa
Author: cstella <ceste...@gmail.com>
Date: 2017-03-24T13:54:31Z
Missed solr
commit 5e614efd861a1d059e04ef64914fc185b111e4b6
Author: cstella <ceste...@gmail.com>
Date: 2017-03-24T13:59:54Z
METRON-797: Pass security.protocol and enable auto-renew for the storm
topologies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
