On Mon, 2007-06-11 at 11:21 +0900, Trustin Lee wrote: > On 6/10/07, peter royal <[EMAIL PROTECTED]> wrote: > > On Jun 8, 2007, at 11:03 PM, Mike Heath wrote: > > > If this functionality is desired, I'll add some Java Docs to the above > > > methods and commit my code and accompanying unit tests. > > > > very nice! looks to be a very useful addition! > > Indeed. I'd like to see this to be included to the trunk.
It's committed to trunk now. > Additionally, the following features might make ByteBuffer more useful: > > * Provide getEnum and putEnum too. (just reading and writing the > ordinal value itself) I like this idea and will get this in soon. > * Throw an IllegalArgumentException if there are too many enum > members. For example, when a user calls putEnumSet with an enum class > which has 10 (>8) members, we need to throw an exception to tell the > user that a wrong value can be written. I like this idea and will add this as well. Validating the data is always a good thing. :) > > Mike, you are a MINA committer so you can check things directly in. A > simple unit test code is appreciated. I just wanted to get some feedback before making the change. Thanks. -Mike
