[ 
https://issues.apache.org/jira/browse/DIRMINA-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507755
 ] 

Mark Webb commented on DIRMINA-389:
-----------------------------------

After performing some more tests, I think I now disagree.  I have created a
test case where I make 2 nearly simultaneous connections to a server using
the ConnectionThrottleFilter and they both pass.  Seeing that this is our
worst case scenario (malicious client blasting the server), I think we may
need to either:

1. speed up the logic in the filter to prevent thread interleavnig
2. use a synchronized map

I vote for #2 to be safe.  In order to support this change, I have made the
clients Map in ConnectionThrottleFilter a synchronized Map using the
Collections class and things work better in my test code.  I can post the
test code if you are interested.





-- 
..Cheers
Mark


> Create a Connection Throttle Filter
> -----------------------------------
>
>                 Key: DIRMINA-389
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-389
>             Project: MINA
>          Issue Type: New Feature
>          Components: Filter
>    Affects Versions: 2.0.0-M1
>         Environment: All
>            Reporter: Mark Webb
>            Assignee: Mark Webb
>            Priority: Minor
>             Fix For: 2.0.0-M1
>
>
> Create a filter that will throttle connections.  This filter will monitor 
> newly created sessions and if new connections from the same IP address come 
> in too fast, drop the connections.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to