+1 import. The code is actually a bit ugly to use, since I have to store
and retrieve the IoSession specific values as session attributes and the
sessionCreated is called elsewhere... In MINA 2.0 this function can be
properly implemented as an IoFilter, since 2.0 allows to have
ProtocolCodecFilters earlier in the chain. But import first, refactor
later..
-Eero
Julien Vermillard wrote:
+1 import, the code is looking nice, and it's a very common need.
Julien
On Thu, 27 Sep 2007 07:24:45 +0900
"Trustin Lee" <[EMAIL PROTECTED]> wrote:
Hi again.
There's an important contribution from Eero Nevalainen that will help
users to implement sending a protocol-specific keep-alive message
periodically:
https://issues.apache.org/jira/browse/DIRMINA-354
It's just a few classes, so I thought we could just import the code,
but procedure is procedure. :)
Software grant has been received long time ago, and also again, it was
not processed on time due to my laziness. There's no reason not to
import these classes IMO; it's just a few classes that makes people's
life a lot easier.
Once vote passes, I will start the paperwork and all the required
procedure.
[ ]: +1, import
[ ] 0, abstain
[ ]: -1, don't import
Cheers,
Trustin
