[
https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530736
]
Jeff Genender commented on DIRMINA-443:
---------------------------------------
Well...the close() is shutting everything down, so we really don't want more
connections ;-) Isn't setting a timeout to 0 also a breakout of the loop in a
similar fashion as the closeFlag? ;-)
However, I agree, setting the timeout to 0 will do what is needed here...but
setting that seems counter intuitive. I think having a close() method (which
can set the timeout to zero) makes sense since it signifies you are shutting it
down manually. If not that, then it should be heavily documented in the wiki
since this question (how to immediately shutdown a SocketConnection) seems to
be a frequently asked question on the lists. I say this because it took me a
good few hours of going through the Mina code to figure out setting the timeout
to 0 shuts it all down ;-) I'm just being nit-picky ;-)
May I submit a new patch to undo the first patch and have close() just set the
timeout to 0, or a patch just to back it out all together and we live with the
timeout=0?
> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
> Key: DIRMINA-443
> URL: https://issues.apache.org/jira/browse/DIRMINA-443
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.0-M1
> Reporter: Jeff Genender
> Assignee: Maarten Bosteels
> Fix For: 2.0.0-M1
>
> Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain
> amount of timeout as specified by the worker timeout to shut down the
> connection. This can result in OOM and hanging clients until the timeouts
> occur. Mina should allow the SocketConnection to be closed manually if the
> connection is known to be completed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
