On Nov 15, 2007 10:22 AM, Trustin Lee <[EMAIL PROTECTED]> wrote:
>
> On Nov 14, 2007 10:28 PM, Niklas Therning <[EMAIL PROTECTED]> wrote:
> > Trustin Lee wrote:
> > > Hi folks,
> > >
> > > I've just added DefaultIoFilterChainBuilder.setFilters() that is very
> > > friendly to existing IoC containers such as Springframework. This
> > > mean we can remove
> > >
> > > * IoFilterMapping
> > > * DefaultIoFilterChainBuilderFactoryBean
> > >
> > > ThreadPoolExecutorFactoryBean is also of dubious value with new
> > > OrderedThreadPoolExecutor and UnorderedThreadPoolExecutor.
> > >
> > > What do you think about removing these three classes?
> > >
> > > Trustin
> > >
> > +1 If these aren't needed anymore I'm all for removing them.
>
> I've just removed the three classes and moved all PropertyEditor
> implementations into org.apache.mina.integration.beans in mina-core
> because they are shared among all IoC frameworks - Springframework,
> Picocontainer and JBoss Microcontainer. I hope you like this move. :)
>
> Now what's left in mina-integration-spring are SSL helper classes
> only. I'm even thinking about getting rid of them. I thought about
> using Not-Yet-Commons-SSL (http://juliusdavies.ca/commons-ssl/), but
> I'm not sure if it can effectively replace the helper classes. WDYT?
Alternatively, we could remove dependency on Springframework in our
helper classes and do like the following (Please forgive my bad Spring
XML :):
<bean id="sslContextFactory" class="...SslContextFactory">
...
</bean>
<bean class="...">
<property name="sslContext" ref="sslContextFactory.newInstance"/>
</bean>
I'm not sure if this is convenient or not though. One advantage is
that we can use the helper classes with other containers. Any feed
back is welcome.
Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6
